ed9ac9b6fe
ARM926: more cleanup
...
An init_target() wrapper isn't needed, and target_create()
can shrink a bit. Add a header comment and some doxygen.
Remove arm926ejs_catch_broken_irscan() which has been a NOP
for quite a few months now, and in any case duplicates logic
in the JTAG core to validate IR capture data. But force the
capture mask to 0x0f, so those tests are most effective.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
2009-11-05 20:35:47 -08:00
aab023570b
ARM920: remove exports and forward decls
...
Unneeded exports cause confusion about the module interfaces.
Make most functions static. Add a short header comment.
The forward decls are just code clutter; remove them, by moving
their references after definitions. This is another file which
never needed even one internal forward declaration.
This saved almost 900 bytes of code on x86_32; it seems the
compiler can leverage its knowledge that these functions are
not called from the outside world...
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
2009-11-05 20:35:37 -08:00
36b4ac90e4
Improve str9xpec command argument parsing.
2009-11-05 18:19:19 -08:00
fa9e5d1027
Improve str9x config command argument parsing.
2009-11-05 18:19:19 -08:00
111b7a6a9d
Improve str7x config command argument parsing.
2009-11-05 18:19:19 -08:00
aa9351ba46
Improve stm32x.c command argument parsing.
2009-11-05 18:19:19 -08:00
786106d725
Improve stellaris.c erase argument parsing.
2009-11-05 18:19:19 -08:00
fc116380bf
Improve pic32mx.c command argument parsing.
2009-11-05 18:19:18 -08:00
ee4723c494
Improve mflash.c command argument parsing.
2009-11-05 18:19:18 -08:00
c63671e4f7
Improve lpc3180_nand_controller.c parsing.
...
This fixes a memory leak in lpc3180_nand_device_command by
reordering the malloc to occur after all parsing has completed.
2009-11-05 18:19:18 -08:00
7b2d8d93e6
Improve lpc2900.c command argument parsing.
2009-11-05 18:19:18 -08:00
0004691e91
Improve lpc288x.c command argument parsing.
2009-11-05 18:19:18 -08:00
7f6ad49d12
Improve lpc2000.c command argument parsing.
2009-11-05 18:19:18 -08:00
680e22c4d7
Improve cfi.c command argument parsing.
2009-11-05 18:19:18 -08:00
7b3d54a127
Improve avrf.c command argument parsing.
2009-11-05 18:19:18 -08:00
266c423bbd
Improve orion_nand.c command argument parsing.
2009-11-05 18:19:18 -08:00
7b49739790
Improve davinci_nand.c command argument parsing.
2009-11-05 18:19:18 -08:00
75b601b1f3
Improve at91sam7.c command argument parsing.
2009-11-05 18:19:13 -08:00
5e0ee6ab08
Improve at91sam3.c command argument parsing.
2009-11-05 18:03:20 -08:00
93ab9ce888
Improve nand.c command argument parsing.
2009-11-05 18:03:20 -08:00
e9566a4a6a
Improve flash.c command argument parsing.
2009-11-05 18:03:20 -08:00
11e545f560
Add Flash/NAND bank command argument helpers.
...
This eliminates redundant code for parsing and retreiving the bank
specified from a script command argument. This patch was written to
replace existing functionality; however, the parsing logic can be
updated later to allow flash commands to accept bank names as well as
their numbers.
2009-11-05 18:03:20 -08:00
4189fdad28
Improve ETM tracemode update command.
2009-11-05 18:03:20 -08:00
d660721ba8
Improve etm command argument parsing.
2009-11-05 18:03:20 -08:00
04b8a2a6f3
Improve trace command argument parsing.
2009-11-05 18:03:19 -08:00
a8886cdfee
Improve arm_adi_v5 command argument parsing.
2009-11-05 18:03:19 -08:00
9b3781e5a4
Improve cortex_m3 command argument parsing.
2009-11-05 18:03:19 -08:00
af84cd33a2
Improve xscale command argument parsing.
2009-11-05 18:03:19 -08:00
4d67b0974f
Improve arm11 command argument parsing.
2009-11-05 18:03:19 -08:00
b699aef4c0
Improve arm966e command argument parsing.
2009-11-05 18:03:19 -08:00
f8f1ac8865
Improve arm926ejs command argument parsing.
2009-11-05 18:03:19 -08:00
714d92a954
Improve arm920t command argument parsing.
2009-11-05 18:03:19 -08:00
0442bda216
Improve arm720t command argument parsing.
2009-11-05 18:03:19 -08:00
11a0afc932
Improve arm7_9_common command argument parsing.
2009-11-05 18:03:19 -08:00
3541ed3aa3
Improve armv7m command argument parsing.
2009-11-05 18:03:19 -08:00
3dd5c59d7d
Improve armv7a command argument parsing.
2009-11-05 18:03:19 -08:00
b62ee5a3c5
Improve armv4_5 command argument parsing.
2009-11-05 18:03:19 -08:00
ab33bdd46c
Improve xscale command argument parsing.
2009-11-05 18:03:19 -08:00
6e542407e7
Improve pld command argument parsing.
2009-11-05 18:03:19 -08:00
2b78a4e82b
Update all server port command to use new helper.
2009-11-05 18:03:19 -08:00
ae5732b9e4
Add server port command helper function.
2009-11-05 18:03:18 -08:00
653ea7b25c
Improve target.c command argument parsing.
...
Passes cmd_ctx into parse_load_image_command_args for reporting the
parsing errors therein.
2009-11-05 18:03:18 -08:00
b7b561aae8
Improve jtag command argument parsing.
2009-11-05 18:03:18 -08:00
f6f1dbfafd
Improve debug_level command argument parsing.
2009-11-05 18:03:18 -08:00
36a3646c22
Add macro for parsing numeric command arguments.
...
This helper eliminates significant amount of redundant code in command
handler functions throughout the system. It wraps the lower-level
parse_* macros to implement a policy for reporting parse errors to the
active command context (cmd_ctx). If errors do occur, this macro causes
the calling function to abort with the proper return code.
2009-11-05 17:27:25 -08:00
68785af4da
Add stringify macros in src/helper/types.h.
2009-11-05 17:20:18 -08:00
0f3117c19d
arm920t: add mrcmcr interface fn's.
...
The arm920t has a concept of read modify write cycles
that may have to be represented in the mrcmcr interface
eventually.
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2009-11-05 23:57:49 +01:00
dc98c64d71
arm11: check if target is halted before executing mrc/mcr commands.
...
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2009-11-05 23:57:49 +01:00
051eaf7950
target: fix ordering of arguments to mcr and mrc commands
...
Now matches machine code syntax and old arm11 syntax.
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2009-11-05 23:57:49 +01:00
4e3c2676f1
target: check args to mrc/mcr.
...
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
2009-11-05 23:57:49 +01:00
David Brownell
Zachary T Welch
Øyvind Harboe