zcy
/
tinyriscv-openocd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

flash: fix sam3 page read/write address computation error 

In at91sam3.c for Atmel SAM3 flash support, there are arithmetic errors in the functions sam3_page_read() and sam3_page_write().
Address locations are computed incorrectly due to an extra addition operation. This leads to memory locations being skipped during
flash writes and reads.

Smaller programs are written successfully into flash, with memory gaps, while larger programs of legitimate size fail because the
skipped memory is not utilized and therefore unavailable.

The changes address this condition, and have been tested with an Atmel SAM3X-EK evaluation board.

Change-Id: I9ea3b9ed0130b71cbc32b2294e31a6a2bc71b47a
Signed-off-by: Chuen Chou <zhouquan27@gmail.com>
Reviewed-on: http://openocd.zylin.com/806
Tested-by: jenkins
Reviewed-by: Freddie Chopin <freddie.chopin@gmail.com>
__archive__
Chuen Chou 2012-09-02 00:45:15 -07:00 committed by Freddie Chopin
parent 8a197f0bbc
commit e26ddb627b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/flash/nor/at91sam3.c
View File

@ -3018,7 +3018,7 @@ static int sam3_page_read(struct sam3_bank_private *pPrivate, unsigned pagenum,
int r; int r;
adr = pagenum * pPrivate->page_size; adr = pagenum * pPrivate->page_size;
adr += adr + pPrivate->base_address; adr += pPrivate->base_address;
r = target_read_memory(pPrivate->pChip->target, r = target_read_memory(pPrivate->pChip->target,
adr, adr,
@ -3126,7 +3126,7 @@ static int sam3_page_write(struct sam3_bank_private *pPrivate, unsigned pagenum,
int r; int r;
adr = pagenum * pPrivate->page_size; adr = pagenum * pPrivate->page_size;
adr += (adr + pPrivate->base_address); adr += pPrivate->base_address;
/* Get flash mode register value */ /* Get flash mode register value */
r = target_read_u32(pPrivate->pChip->target, pPrivate->controller_address, &fmr); r = target_read_u32(pPrivate->pChip->target, pPrivate->controller_address, &fmr);