From bb8c0d55d4fa72fe48ef70f17ee40324a355b73f Mon Sep 17 00:00:00 2001 From: Luca BRUNO Date: Thu, 22 Aug 2013 16:22:31 +0200 Subject: [PATCH] NULL check before dereferencing Check reg_list[i]->feature for NULL pointers before checking feature->name in order to avoid NULL access. Change-Id: If20401a6c5aa5e1e29f0fcf9bb95585b49658832 Signed-off-by: Luca BRUNO Reviewed-on: http://openocd.zylin.com/1809 Tested-by: jenkins Reviewed-by: Peter Stuge Reviewed-by: Jens Bauer --- src/server/gdb_server.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/server/gdb_server.c b/src/server/gdb_server.c index c49f87c1c..c578780c8 100644 --- a/src/server/gdb_server.c +++ b/src/server/gdb_server.c @@ -1988,7 +1988,8 @@ static int get_reg_features_list(struct target *target, char **feature_list[], i if (reg_list[i]->exist == false) continue; - if ((reg_list[i]->feature->name != NULL) + if (reg_list[i]->feature != NULL + && reg_list[i]->feature->name != NULL && (strcmp(reg_list[i]->feature->name, ""))) { /* We found a feature, check if the feature is already in the * table. If not, allocate a new entry for the table and