zcy
/
tinyriscv-openocd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add check for target_read/write_buffer 32 bit wrap. 

git-svn-id: svn://svn.berlios.de/openocd/trunk@875 b42882b7-edfa-0310-969c-e2dbd0fdcd60
__archive__
oharboe 2008-07-26 19:12:30 +00:00
parent 53590217ee
commit b82a189c4e
1 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/target/target.c
View File

@ -969,13 +969,20 @@ int target_arch_state(struct target_s *target)
int target_write_buffer(struct target_s *target, u32 address, u32 size, u8 *buffer) int target_write_buffer(struct target_s *target, u32 address, u32 size, u8 *buffer)
{ {
int retval; int retval;
LOG_DEBUG("writing buffer of %i byte at 0x%8.8x", size, address);
if (!target->type->examined) if (!target->type->examined)
{ {
LOG_ERROR("Target not examined yet"); LOG_ERROR("Target not examined yet");
return ERROR_FAIL; return ERROR_FAIL;
} }
LOG_DEBUG("writing buffer of %i byte at 0x%8.8x", size, address); if (address+size<address)
{
/* GDB can request this when e.g. PC is 0xfffffffc*/
LOG_ERROR("address+size wrapped(0x%08x, 0x%08x)", address, size);
return ERROR_FAIL;
}
if (((address % 2) == 0) && (size == 2)) if (((address % 2) == 0) && (size == 2))
{ {
@ -1038,13 +1045,20 @@ int target_write_buffer(struct target_s *target, u32 address, u32 size, u8 *buff
int target_read_buffer(struct target_s *target, u32 address, u32 size, u8 *buffer) int target_read_buffer(struct target_s *target, u32 address, u32 size, u8 *buffer)
{ {
int retval; int retval;
LOG_DEBUG("reading buffer of %i byte at 0x%8.8x", size, address);
if (!target->type->examined) if (!target->type->examined)
{ {
LOG_ERROR("Target not examined yet"); LOG_ERROR("Target not examined yet");
return ERROR_FAIL; return ERROR_FAIL;
} }
LOG_DEBUG("reading buffer of %i byte at 0x%8.8x", size, address); if (address+size<address)
{
/* GDB can request this when e.g. PC is 0xfffffffc*/
LOG_ERROR("address+size wrapped(0x%08x, 0x%08x)", address, size);
return ERROR_FAIL;
}
if (((address % 2) == 0) && (size == 2)) if (((address % 2) == 0) && (size == 2))
{ {