zcy
/
tinyriscv-openocd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

flash/nor/jtagspi: 'retval' may be used uninitialized 

Problem
As my compiler has "warnings being treated as errors" on, it shows the
error message:
  error: 'retval' may be used uninitialized in this function

Investigation
Nothing wrong with the logic, 'retval' would have a value before returning.
Just wanna get rid of the compiling "warning as error" message.

Solution
Provide a reasonable default value

Change-Id: I712c15f82819c6c48bee9dceca8de4b18aeb29b0
Signed-off-by: Alamy Liu <alamy.liu@gmail.com>
Reviewed-on: http://openocd.zylin.com/2905
Tested-by: jenkins
Reviewed-by: Robert Jordens <jordens@gmail.com>
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
__archive__
Alamy Liu 2015-08-06 14:45:19 -07:00 committed by Andreas Fritiofson
parent 2dcf7bf77d
commit 85903156d7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/flash/nor/jtagspi.c
View File

@ -272,7 +272,7 @@ static int jtagspi_erase(struct flash_bank *bank, int first, int last)
{
int sector;
struct jtagspi_flash_bank *info = bank->driver_priv;
int retval;
int retval = ERROR_OK;
LOG_DEBUG("erase from sector %d to sector %d", first, last);