zcy
/
tinyriscv-openocd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify and clean handle_virt2phys_command: 

- Add a doxygen block to simplify logic.
- Move declarations to point of first use.


git-svn-id: svn://svn.berlios.de/openocd/trunk@2194 b42882b7-edfa-0310-969c-e2dbd0fdcd60
__archive__
zwelch 2009-06-11 11:42:54 +00:00
parent 57612ecf1d
commit 7c892082c9
1 changed files with 15 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/target/target.c
View File

@ -2575,30 +2575,27 @@ static int handle_rwp_command(struct command_context_s *cmd_ctx, char *cmd, char
return ERROR_OK; return ERROR_OK;
} }
static int handle_virt2phys_command(command_context_t *cmd_ctx, char *cmd, char **args, int argc)
/**
* Translate a virtual address to a physical address.
*
* The low-level target implementation must have logged a detailed error
* which is forwarded to telnet/GDB session.
*/
static int handle_virt2phys_command(command_context_t *cmd_ctx,
char *cmd, char **args, int argc)
{ {
int retval; if (argc != 1)
return ERROR_COMMAND_SYNTAX_ERROR;
target_t *target = get_current_target(cmd_ctx); target_t *target = get_current_target(cmd_ctx);
u32 va; u32 va = strtoul(args[0], NULL, 0);
u32 pa; u32 pa;
if (argc != 1) int retval = target->type->virt2phys(target, va, &pa);
{
return ERROR_COMMAND_SYNTAX_ERROR;
}
va = strtoul(args[0], NULL, 0);
retval = target->type->virt2phys(target, va, &pa);
if (retval == ERROR_OK) if (retval == ERROR_OK)
{
command_print(cmd_ctx, "Physical address 0x%08x", pa); command_print(cmd_ctx, "Physical address 0x%08x", pa);
}
else
{
/* lower levels will have logged a detailed error which is
* forwarded to telnet/GDB session.
*/
}
return retval; return retval;
} }