zcy
/
tinyriscv-openocd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

change command_find helper interface 

Avoid requiring double pointers where a single would suffice.
__archive__
Zachary T Welch 2009-11-19 07:26:28 -08:00
parent 67c29d9935
commit 73c6e3bb18
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/helper/command.c
View File

@ -205,10 +205,9 @@ static void command_helptext_add(Jim_Obj *cmd_list, const char *help)
* Find a command by name from a list of commands. * Find a command by name from a list of commands.
* @returns The named command if found, or NULL. * @returns The named command if found, or NULL.
*/ */
static struct command *command_find(struct command **head, const char *name) static struct command *command_find(struct command *head, const char *name)
{ {
assert(head); for (struct command *cc = head; cc; cc = cc->next)
for (struct command *cc = *head; cc; cc = cc->next)
{ {
if (strcmp(cc->name, name) == 0) if (strcmp(cc->name, name) == 0)
return cc; return cc;
@ -242,7 +241,7 @@ struct command* register_command(struct command_context *context,
return NULL; return NULL;
struct command **head = parent ? &parent->children : &context->commands; struct command **head = parent ? &parent->children : &context->commands;
struct command *c = command_find(head, name); struct command *c = command_find(*head, name);
if (NULL != c) if (NULL != c)
return c; return c;