zcy
/
tinyriscv-openocd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

helper/command: log an error for commands without usage 

Every command has been fixed with proper usage field.
Change LOG_DEBUG with LOG_ERROR so a developer will get a visible
alert for missing usage field when adds a new command.

Change-Id: I077c3745fd6265aded8e54b3f9d202d4d6516966
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5026
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
bscan_optimization
Antonio Borneo 2019-03-30 08:47:38 +01:00 committed by Tomas Vanek
parent 38d053d11b
commit 6f04bc1568
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/helper/command.c
View File

@ -316,7 +316,7 @@ static struct command *command_new(struct command_context *cmd_ctx,
* arguments. * arguments.
*/ */
if ((cr->jim_handler == NULL) && (cr->usage == NULL)) { if ((cr->jim_handler == NULL) && (cr->usage == NULL)) {
LOG_DEBUG("BUG: command '%s%s%s' does not have the " LOG_ERROR("BUG: command '%s%s%s' does not have the "
"'.usage' field filled out", "'.usage' field filled out",
parent && parent->name ? parent->name : "", parent && parent->name ? parent->name : "",
parent && parent->name ? " " : "", parent && parent->name ? " " : "",