Update HACKING info
Inform about possibility of discarding negative review in Gerrit when specific conditions are met. Change-Id: I432b6c93cefc368fa22ce1096bea4cd174e03816 Signed-off-by: Freddie Chopin <freddie.chopin@gmail.com> Reviewed-on: http://openocd.zylin.com/747 Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com> Tested-by: Øyvind Harboe <oyvindharboe@gmail.com>__archive__
parent
3d62c3df6d
commit
57aa19f846
7
HACKING
7
HACKING
|
@ -152,6 +152,13 @@ master branch will be much reduced.
|
||||||
If a contributor pushes a patch, it is considered good form if another
|
If a contributor pushes a patch, it is considered good form if another
|
||||||
contributor actually approves and submits that patch.
|
contributor actually approves and submits that patch.
|
||||||
|
|
||||||
|
It should be noted that a negative review in Gerrit ("-1" or "-2") may (but does
|
||||||
|
not have to) be disregarded if all conditions listed below are met:
|
||||||
|
|
||||||
|
- the concerns raised in the review have been addressed (or explained),
|
||||||
|
- reviewer does not re-examine the change in a month,
|
||||||
|
- reviewer does not answer e-mails for another month.
|
||||||
|
|
||||||
@section browsing Browsing Patches
|
@section browsing Browsing Patches
|
||||||
All OpenOCD patches can be reviewed <a href="http://openocd.zylin.com/">here</a>.
|
All OpenOCD patches can be reviewed <a href="http://openocd.zylin.com/">here</a>.
|
||||||
*/
|
*/
|
||||||
|
|
Loading…
Reference in New Issue