zcy
/
tinyriscv-openocd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add warnings about not using in_handler 

git-svn-id: svn://svn.berlios.de/openocd/trunk@1609 b42882b7-edfa-0310-969c-e2dbd0fdcd60
__archive__
oharboe 2009-05-06 06:40:56 +00:00
parent 4d88c124b1
commit 213368e21f
3 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/jtag/jtag.h
View File

@ -273,9 +273,9 @@ typedef struct scan_field_s
u8* out_value; /* value to be scanned into the device */ u8* out_value; /* value to be scanned into the device */
u8* in_value; /* pointer to a 32-bit memory location to take data scanned out */ u8* in_value; /* pointer to a 32-bit memory location to take data scanned out */
/* in_check_value/mask, in_handler_error_handler, in_handler_priv can be used by the in handler, otherwise they contain garbage */ /* in_check_value/mask, in_handler_error_handler, in_handler_priv can be used by the in handler, otherwise they contain garbage */
u8* in_check_value; /* used to validate scan results */ u8* in_check_value; /* deprecated! only used from jtag_set_check_value. used to validate scan results */
u8* in_check_mask; /* check specified bits against check_value */ u8* in_check_mask; /* deprecated! only used from jtag_set_check_value. check specified bits against check_value */
in_handler_t in_handler; /* process received buffer using this handler */ in_handler_t in_handler; /* deprecated! DO NOT USE! process received buffer using this handler */
void* in_handler_priv; /* additional information for the in_handler */ void* in_handler_priv; /* additional information for the in_handler */
} scan_field_t; } scan_field_t;
@ -580,10 +580,10 @@ extern int interface_jtag_add_tlr(void);
* of the same interface over time. Even if the OpenOCD code * of the same interface over time. Even if the OpenOCD code
* is unchanged, the actual path taken may vary over time * is unchanged, the actual path taken may vary over time
* and versions of interface firmware or PCB revisions. * and versions of interface firmware or PCB revisions.
* *
* Use jtag_add_pathmove() when specific transition sequences * Use jtag_add_pathmove() when specific transition sequences
* are required. * are required.
* *
* Do not use jtag_add_pathmove() unless you need to, but do use it * Do not use jtag_add_pathmove() unless you need to, but do use it
* if you have to. * if you have to.
* *

12
src/target/mips_ejtag.c
View File

@ -32,7 +32,7 @@
#include <stdlib.h> #include <stdlib.h>
int mips_ejtag_set_instr(mips_ejtag_t *ejtag_info, int new_instr, in_handler_t handler) int mips_ejtag_set_instr(mips_ejtag_t *ejtag_info, int new_instr, void *delete_me_and_submit_patch)
{ {
jtag_tap_t *tap; jtag_tap_t *tap;
@ -49,11 +49,11 @@ int mips_ejtag_set_instr(mips_ejtag_t *ejtag_info, int new_instr, in_handler_t h
field.num_bits = tap->ir_length; field.num_bits = tap->ir_length;
field.out_value = t; field.out_value = t;
buf_set_u32(field.out_value, 0, field.num_bits, new_instr); buf_set_u32(field.out_value, 0, field.num_bits, new_instr);
field.in_value = NULL; field.in_value = NULL;
field.in_check_value = NULL; field.in_check_value = NULL;
field.in_check_mask = NULL; field.in_check_mask = NULL;
field.in_handler = handler; field.in_handler = NULL;
field.in_handler_priv = NULL; field.in_handler_priv = NULL;
jtag_add_ir_scan(1, &field, TAP_INVALID); jtag_add_ir_scan(1, &field, TAP_INVALID);
} }
@ -72,7 +72,7 @@ int mips_ejtag_get_idcode(mips_ejtag_t *ejtag_info, u32 *idcode, in_handler_t ha
field.tap = ejtag_info->tap; field.tap = ejtag_info->tap;
field.num_bits = 32; field.num_bits = 32;
field.out_value = NULL; field.out_value = NULL;
field.in_value = (void*)idcode; field.in_value = (void*)idcode;
field.in_check_value = NULL; field.in_check_value = NULL;
field.in_check_mask = NULL; field.in_check_mask = NULL;
@ -99,7 +99,7 @@ int mips_ejtag_get_impcode(mips_ejtag_t *ejtag_info, u32 *impcode, in_handler_t
field.tap = ejtag_info->tap; field.tap = ejtag_info->tap;
field.num_bits = 32; field.num_bits = 32;
field.out_value = NULL; field.out_value = NULL;
field.in_value = (void*)impcode; field.in_value = (void*)impcode;
field.in_check_value = NULL; field.in_check_value = NULL;
field.in_check_mask = NULL; field.in_check_mask = NULL;
@ -130,7 +130,7 @@ int mips_ejtag_drscan_32(mips_ejtag_t *ejtag_info, u32 *data)
field.num_bits = 32; field.num_bits = 32;
field.out_value = t; field.out_value = t;
buf_set_u32(field.out_value, 0, field.num_bits, *data); buf_set_u32(field.out_value, 0, field.num_bits, *data);
field.in_value = (u8*)data; field.in_value = (u8*)data;
field.in_check_value = NULL; field.in_check_value = NULL;
field.in_check_mask = NULL; field.in_check_mask = NULL;

2
src/target/mips_ejtag.h
View File

@ -107,7 +107,7 @@ typedef struct mips_ejtag_s
u32 ejtag_ctrl; u32 ejtag_ctrl;
} mips_ejtag_t; } mips_ejtag_t;
extern int mips_ejtag_set_instr(mips_ejtag_t *ejtag_info, int new_instr, in_handler_t handler); extern int mips_ejtag_set_instr(mips_ejtag_t *ejtag_info, int new_instr, void *delete_me_and_submit_patch);
extern int mips_ejtag_enter_debug(mips_ejtag_t *ejtag_info); extern int mips_ejtag_enter_debug(mips_ejtag_t *ejtag_info);
extern int mips_ejtag_exit_debug(mips_ejtag_t *ejtag_info, int enable_interrupts); extern int mips_ejtag_exit_debug(mips_ejtag_t *ejtag_info, int enable_interrupts);
extern int mips_ejtag_get_impcode(mips_ejtag_t *ejtag_info, u32 *impcode, in_handler_t handler); extern int mips_ejtag_get_impcode(mips_ejtag_t *ejtag_info, u32 *impcode, in_handler_t handler);