zcy
/
tinyriscv-openocd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't cache PC, but do cache DPC. (#473) 

This fixes a bug where we read PC and marked it cached without actually
updating the cached value. The DPC value was correctly marked as valid
and updated.

Change-Id: Id6d3e94a96b981688b06f7f4a998019f2c02f6f5
riscv
Tim Newsome 2020-05-06 08:43:59 -07:00 committed by GitHub
parent 55dd7e83ca
commit 0c3e50a06a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/target/riscv/riscv.c
View File

@ -3015,13 +3015,15 @@ static bool gdb_regno_cacheable(enum gdb_regno regno, bool write)
/* GPRs, FPRs, vector registers are just normal data stores. */ /* GPRs, FPRs, vector registers are just normal data stores. */
if (regno <= GDB_REGNO_XPR31 || if (regno <= GDB_REGNO_XPR31 ||
(regno >= GDB_REGNO_FPR0 && regno <= GDB_REGNO_FPR31) || (regno >= GDB_REGNO_FPR0 && regno <= GDB_REGNO_FPR31) ||
(regno >= GDB_REGNO_V0 && regno <= GDB_REGNO_V31) || (regno >= GDB_REGNO_V0 && regno <= GDB_REGNO_V31))
regno == GDB_REGNO_PC)
return true; return true;
/* Most CSRs won't change value on us, but we can't assume it about rbitrary /* Most CSRs won't change value on us, but we can't assume it about rbitrary
* CSRs. */ * CSRs. */
switch (regno) { switch (regno) {
case GDB_REGNO_DPC:
return true;
case GDB_REGNO_VSTART: case GDB_REGNO_VSTART:
case GDB_REGNO_VXSAT: case GDB_REGNO_VXSAT:
case GDB_REGNO_VXRM: case GDB_REGNO_VXRM:
@ -3029,7 +3031,6 @@ static bool gdb_regno_cacheable(enum gdb_regno regno, bool write)
case GDB_REGNO_VL: case GDB_REGNO_VL:
case GDB_REGNO_VTYPE: case GDB_REGNO_VTYPE:
case GDB_REGNO_MISA: case GDB_REGNO_MISA:
case GDB_REGNO_DPC:
case GDB_REGNO_DCSR: case GDB_REGNO_DCSR:
case GDB_REGNO_DSCRATCH: case GDB_REGNO_DSCRATCH:
case GDB_REGNO_MSTATUS: case GDB_REGNO_MSTATUS: