Commit Graph

25 Commits (ae2394f086ff4694043b24f80611d6cacf3eee6d)

Author SHA1 Message Date
Brett Zamir ae2394f086 (INCOMPLETE: ES6 Module conversion and linting)
- Breaking change: Require `new` with `EmbeddedSVGEdit` (allows us to use `class` internally)
- Breaking change: If `svgcanvas.setUiStrings` must now be called if not using editor in order
    to get strings (for sake of i18n) (and if using path.js alone, must also have its `setUiStrings` called)
- Breaking change (ext-overview-window): Avoid global `overviewWindowGlobals`
- Breaking change (ext-imagelib): Change to object-based encoding for namespacing of
    messages (though keep stringifying/parsing ourselves until we remove IE9 support)
- Breaking change: Rename `jquery.js` to `jquery.min.js`
- Breaking change: Remove `scoped` attribute from `style`; it is now deprecated and
    obsolete; also move to head (after other stylesheets)
- Enhancement: Make SpinButton plugin independent of SVGEdit via
    generic state object for tool_scale
- Enhancement: Remove now unused Python l10n scripts (#238)
- Enhancement: ES6 Modules (including jQuery plugins but not jQuery)
- Enhancement: Further JSDoc (incomplete)
- Enhancement (Optimization): Compress images using imageoptim (and add
    npm script) (per #215)
- Fix: i18nize path.js strings and canvas notifications
- Fix: Attempt i18n for ext-markers
- Refactoring (ext-storage): Move locale info to own file imported by the extension (toward modularity; still should be split into separate files by language and *dynamically* imported, but we'll wait for better `import` support to refactor this)
- Refactoring: For imagelib, add local jQuery copy (using old 1.4.4 as had
    been using from server)
- Refactoring: For MathJax, add local copy (using old 2.3 as had been using from
    server); server had not been working
- Refactoring: Remove `use strict` (implicit in modules)
- Refactoring: Remove trailing whitespace, fix some code within comments
- Refactoring: Expect `jQuery` global rather than `$` for better modularity
    (also to adapt line later once available via `import`)
- Refactoring: Prefer `const` (and then `let`)
- Refactoring: Add block scope keywords closer to first block in which they appear
- Refactoring: Use ES6 `class`
- Refactoring `$.isArray` -> `Array.isArray` and avoid some other jQuery core methods
    with simple VanillaJS replacements
- Refactoring: Use abbreviated object property syntax
- Refactoring: Object destructuring
- Refactoring: Remove `uiStrings` contents in svg-editor.js (obtains from locale)
- Refactoring: Add favicon to embedded API file
- Refactoring: Use arrow functions for brief functions (incomplete)
- Refactoring: Use `Array.prototype.includes`/`String.prototype.includes`;
    `String.prototype.startsWith`, `String.prototype.trim`
- Refactoring: Remove now unnecessary svgutils do/while resetting of variables
- Refactoring: Use shorthand methods for object literals (avoid ": function")
- Refactoring: Avoid quoting object property keys where unnecessary
- Refactoring: Just do truthy/falsey check for lengths in place of comparison to 0
- Refactoring (Testing): Avoid jQuery usage within most test files (defer script,
    also in preparation for future switch to ES6 modules for tests)
- Refactoring: Make jpicker variable declaration indent bearable
- Refactoring (Linting): Finish svgcanvas.js
- Docs: Mention in comment no longer an entry file as before
- Docs: Migrate old config, extensions, and FAQ docs
- Licensing: Indicate MIT is license type of rgbcolor; rename/add license file name for
    jgraduate and screencast to reflect type (Apache 2.0); rename file to reflect it
    contains license information (of type MIT) for Raphael icons
2018-05-22 18:02:57 +08:00
Brett Zamir 52353c6321 - Further convert tabs -> 2 spaces in JS code comments (except in test performance
file where used for alignment though use tab escape within JS), CSS
    (including comments), PHP, SVG, JSON, XUL
- Remove extra spaces in svgcanvas.js, ext-connector.js
2018-05-18 14:41:43 +08:00
codedread 4043c6e537 Change all tab indentations to 2sp indentation. Addresses issue #37 2018-05-17 21:02:30 -07:00
Brett Zamir a3b3525789 - Linting (ESLint): Finish
- Fix: Globals (x, y) in `mouseMove`
- Fix: Global (element, d_attr->dAttr) in `mouseDown`
- Fix: Avoid `drawnPath` not defined error
- Docs: sp.
2018-05-17 11:34:21 +08:00
Brett Zamir 340915be4e - Linting (ESLint): Finish extensions and most files in editor/; unfinished: `editor/svg-editor.js`, `editor/svgcanvas.js`
- Linting (ESLint): Fix ignore file paths
- History `elem` fix
2018-05-16 12:08:41 +08:00
codedread 6f7aa650f8 Allow data- attributes in the sanitize whitelist. Fixes issue #203. 2017-11-29 07:52:02 -08:00
Philip Rogers 7e3f9e037d Add pathseg.js, a polyfill for the SVGPathSeg API
The SVGPathSeg API is being removed from the spec [1] and is being
removed in Chromium 47 [2]. I implemented a drop-in polyfill[3] so
svg-edit users are not broken as browsers migrate away from the
path seg api.

This patch simply imports the upstream pathseg.js and updates all
dependencies. With this change all tests pass in Chrome 46 (with
the path seg api), Chrome 47 (without the path seg api), and
there are no changes to tests in Safari 9.01 or Firefox 43. I
also manually tested svg-edit while developing the polyfill and
could not find any broken features.

[1] https://lists.w3.org/Archives/Public/www-svg/2015Jun/0044.html
[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/EDC3cBg9mCU/OvElJgOWCgAJ
[3] https://github.com/progers/pathseg
2015-11-04 19:25:30 -08:00
Brett Zamir e07d4e61be Change deprecated Attr.nodeValue to Attr.value
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@2819 eee81c28-f429-11dd-99c0-75d572ba1ddd
2014-04-09 05:38:20 +00:00
Brett Zamir d12694f9fa More JSLint
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@2642 eee81c28-f429-11dd-99c0-75d572ba1ddd
2014-01-31 01:05:03 +00:00
Waldir Pimenta 00043ff56a use 2 spaces for indentation in sanitize.js
See r2469 and https://groups.google.com/d/topic/svg-edit/fKGQEZ6h7-g/


git-svn-id: http://svg-edit.googlecode.com/svn/trunk@2471 eee81c28-f429-11dd-99c0-75d572ba1ddd
2013-02-26 15:21:46 +00:00
Bruno Heridet 2c1c5da6de misc cleaned up sanitize inconsistent indentation
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@2469 eee81c28-f429-11dd-99c0-75d572ba1ddd
2013-02-25 12:39:27 +00:00
Bruno Heridet f9b8aa624c created svgedit main object, moved all namespaces handling in the same place
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@2411 eee81c28-f429-11dd-99c0-75d572ba1ddd
2013-02-16 15:02:26 +00:00
Bruno Heridet e906a0f6fd cleaned quote inconsistencies
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@2397 eee81c28-f429-11dd-99c0-75d572ba1ddd
2013-02-15 17:02:24 +00:00
Bruno Heridet 3d61d46f6b cleaned inconsistencies with comma spacing
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@2396 eee81c28-f429-11dd-99c0-75d572ba1ddd
2013-02-15 16:51:48 +00:00
Waldir Pimenta 7f560c0ed1 minor change so we don't have two variables named "attrName" and "attrname", and make it more explicit that these are style-related attributes.
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@2380 eee81c28-f429-11dd-99c0-75d572ba1ddd
2013-02-13 17:21:13 +00:00
Waldir Pimenta 5dcdc76912 reorder namespaces (put all W3C ones first); align a few lines; tweak comments for consistency and clarity.
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@2379 eee81c28-f429-11dd-99c0-75d572ba1ddd
2013-02-13 17:09:12 +00:00
Waldir Pimenta f43adb25fa code readability/organization: move nsMap_ getter to immediately after it is created. make comment on nsRevMap_ more explicit.
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@2378 eee81c28-f429-11dd-99c0-75d572ba1ddd
2013-02-13 16:37:10 +00:00
Jeff Schiller 936d9cc362 Fix issue 1052: Properly parse the style attribute during sanitization
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@2376 eee81c28-f429-11dd-99c0-75d572ba1ddd
2013-02-13 15:04:58 +00:00
Marc Laporte cf0dde3f4a Updating license information as per http://code.google.com/p/svg-edit/issues/detail?id=959
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@2088 eee81c28-f429-11dd-99c0-75d572ba1ddd
2012-09-16 18:53:27 +00:00
Jeff Schiller 0f85c54128 Potential fix for issue 889, importing problems by adding style element to whitelist (patch by asyazwan)
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@2057 eee81c28-f429-11dd-99c0-75d572ba1ddd
2012-02-26 18:08:34 +00:00
Jacques Distler 6b1483446b Some MathML3 attributes for the Sanitizer (to match itex2MML 1.4.7)
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@2039 eee81c28-f429-11dd-99c0-75d572ba1ddd
2011-09-11 04:15:15 +00:00
Jeff Schiller 6b8958bd39 Turn on Closure compilers SIMPLE_OPTIMIZATIONS. Slightly change how svgedit namespace is set up in each module
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@1931 eee81c28-f429-11dd-99c0-75d572ba1ddd
2011-01-18 06:46:45 +00:00
Jeff Schiller 28b9c0cfd7 Rename browsersupport module to browser
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@1910 eee81c28-f429-11dd-99c0-75d572ba1ddd
2011-01-13 07:47:21 +00:00
Jeff Schiller 383d52e157 Fix error introduced in r1852, accidentally moved uiStrings into sanitize.js
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@1872 eee81c28-f429-11dd-99c0-75d572ba1ddd
2010-11-15 09:24:02 +00:00
Jeff Schiller a681fc2579 Add a sanitize.js module and put sanitizeSvg into it. Fix some browsersupport sniffing calls.
git-svn-id: http://svg-edit.googlecode.com/svn/trunk@1852 eee81c28-f429-11dd-99c0-75d572ba1ddd
2010-11-07 20:14:05 +00:00