zcy
/
svgedit
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Further optimize the base64 encoding function (precalculate array size needed and avoid push) 

git-svn-id: http://svg-edit.googlecode.com/svn/trunk@138 eee81c28-f429-11dd-99c0-75d572ba1ddd
master
Jeff Schiller 2009-06-17 03:20:42 +00:00
parent 033062049f
commit f247e8f1b8
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
editor/svgcanvas.js
View File

@ -84,6 +84,7 @@ function SvgCanvas(c)
} }
var svgToString = function(elem, indent) { var svgToString = function(elem, indent) {
// TODO: could use the array.join() optimization trick here too
var out = ""; var out = "";
if (elem) { if (elem) {
var attrs = elem.attributes; var attrs = elem.attributes;
@ -792,15 +793,17 @@ var Utils = {
// public domain. It would be nice if you left this header intact. // public domain. It would be nice if you left this header intact.
// Base64 code from Tyler Akins -- http://rumkin.com // Base64 code from Tyler Akins -- http://rumkin.com
// schiller: Removed string concatenation in favour of Array.join() optimization // schiller: Removed string concatenation in favour of Array.join() optimization,
// also precalculate the size of the array needed.
"_keyStr" : "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/=", "_keyStr" : "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/=",
"encode64" : function(input) { "encode64" : function(input) {
var output = []; // base64 strings are 4/3 larger than the original string
var output = new Array(parseInt(input.length*4/3));
var chr1, chr2, chr3; var chr1, chr2, chr3;
var enc1, enc2, enc3, enc4; var enc1, enc2, enc3, enc4;
var i = 0; var i = 0, p = 0;
do { do {
chr1 = input.charCodeAt(i++); chr1 = input.charCodeAt(i++);
@ -818,10 +821,10 @@ var Utils = {
enc4 = 64; enc4 = 64;
} }
output.push(this._keyStr.charAt(enc1)); output[p++] = this._keyStr.charAt(enc1);
output.push(this._keyStr.charAt(enc2)); output[p++] = this._keyStr.charAt(enc2);
output.push(this._keyStr.charAt(enc3)); output[p++] = this._keyStr.charAt(enc3);
output.push(this._keyStr.charAt(enc4)); output[p++] = this._keyStr.charAt(enc4);
} while (i < input.length); } while (i < input.length);
return output.join(''); return output.join('');