From c0d0db4d7ec64d918669f6f5c8021d053261297b Mon Sep 17 00:00:00 2001
From: pmkrawczyk <63370626+pmkrawczyk@users.noreply.github.com>
Date: Sun, 27 Nov 2022 10:28:55 +0100
Subject: [PATCH] Prevent accidental selection move (#848)

---
 packages/svgcanvas/event.js | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/packages/svgcanvas/event.js b/packages/svgcanvas/event.js
index 8ea1169e..3d3043c7 100644
--- a/packages/svgcanvas/event.js
+++ b/packages/svgcanvas/event.js
@@ -24,6 +24,7 @@ const {
 } = hstry
 
 let svgCanvas = null
+let moveSelectionThresholdReached = false
 
 /**
 * @function module:undo.init
@@ -155,7 +156,13 @@ const mouseMoveEvent = (evt) => {
           dy = snapToGrid(dy)
         }
 
-        if (dx || dy) {
+        // Enable moving selection only if mouse has been moved at least 4 px in any direction
+        // This prevents objects from being accidentally moved when (initially) selected
+        const deltaThreshold = 4
+        const deltaThresholdReached = Math.abs(dx) > deltaThreshold || Math.abs(dy) > deltaThreshold
+        moveSelectionThresholdReached = moveSelectionThresholdReached || deltaThresholdReached
+
+        if (moveSelectionThresholdReached) {
           selectedElements.forEach((el) => {
             if (el) {
               updateTransformList(svgRoot, el, dx, dy)
@@ -563,6 +570,7 @@ const mouseOutEvent = () => {
 * @returns {void}
 */
 const mouseUpEvent = (evt) => {
+  moveSelectionThresholdReached = false
   if (evt.button === 2) { return }
   if (!svgCanvas.getStarted()) { return }