From bff04dd58a08cf59bf8a1d838830e409fbd68b1c Mon Sep 17 00:00:00 2001 From: Brett Zamir Date: Wed, 3 Apr 2019 17:28:47 +0800 Subject: [PATCH] - Docs (Accessibility): Refer to known issues --- CHANGES.md | 1 + docs/Accessibility.md | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+) create mode 100644 docs/Accessibility.md diff --git a/CHANGES.md b/CHANGES.md index 7e031445..af124108 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -36,6 +36,7 @@ error despite not replicating manually; should file a Testcafe issue - Docs: Some JSDoc descriptions, JSDoc spacing, fix svgIcons param def; add todo +- Docs (Accessibility): Refer to known issues - npm: Update devDeps; update nested deps for security audit; remove one unneeded) diff --git a/docs/Accessibility.md b/docs/Accessibility.md new file mode 100644 index 00000000..ea714895 --- /dev/null +++ b/docs/Accessibility.md @@ -0,0 +1,19 @@ +# Accessibility + +We run some automated accessibility tests to try to ensure best practices +for visually impaired as well as accessibility's benefits for +non-impaired users. + +## Known rule problems + +1. `meta-viewport` - Regarding "Zooming and scaling must not be disabled", + ``; this rule + is ignored in tests, as it is a known issue. We do have our + own zoom controls. It should also require a lot of work to refactor. +1. `color-contrast` - Regarding "Elements must have sufficient color + contrast", the following at least have been reported: + `#sidepanel_handle`, `#main_icon > span`, `#stroke_style`. +1. `duplicate-id`, - Regarding "id attribute value must be unique", the + selector `#fill_color > svg > defs > lineargradient` is being reported, + and it is due to multiple IDs within `editor/images/svg_edit_icons.svg` + (due to internal duplicates and/or because of cloning?).