- Linting: Update per ash-nazg/plugin-node update

- npm: Update devDeps
- npm: Remove unused devDeps

.eslintrc.js

@@ -129,11 +129,15 @@ module.exports = {
         "node/no-missing-import": ["off"]
       }
     },
-    // Dis-apply Node rules mistakenly giving errors with browser files
+    // Dis-apply Node rules mistakenly giving errors with browser files,
+    //  and treating Node global `root` as being present for shadowing
     {
-      files: ["editor/**", "test/**"],
+      files: ["editor/**", "test/**", "screencasts/**"],
+      globals: {
+        root: "off"
+      },
       rules: {
-        "node/no-unsupported-features/node-builtins": ["off"]
+        "node/no-unsupported-features/node-builtins": "off"
       }
     },
     // We want console in tests!
@@ -153,9 +157,15 @@ module.exports = {
       env: {
         node: true,
       },
+      globals: {
+        require: true
+      },
       rules: {
-        "node/no-unpublished-import": ["off"],
+        // We can't put Rollup in npmignore or user can't get access,
-        "node/no-unsupported-features/es-syntax": ["off"]
+        //  and we have too many modules to add to `peerDependencies`
+        //  so this rule can know them to be available, so we instead
+        //  disable
+        "node/no-unpublished-import": "off"
       }
     },
     {
@@ -164,8 +174,12 @@ module.exports = {
       parserOptions: {
         sourceType: "script"
       },
+      globals: {
+        "module": false
+      },
       rules: {
-        "import/no-commonjs": "off"
+        "import/no-commonjs": "off",
+        "strict": "off"
       }
     }
   ],

CHANGES.md

@@ -13,12 +13,14 @@
 - Linting (JSDoc): Update per newly enforced `require-returns`; avoid
   Closure syntax; reenable `jsdoc/valid-jsdoc` as fixed; notes
   re: valid-jsdoc replacement; use same namepath
+- Linting: Update per ash-nazg/plugin-node update
 - Docs (Refactoring): Formally specify `Promise` resolve type;
     add `typedef` for dialog result object; add an
     `ArbitraryCallbackResult` type; prefer `void`
 - Build: Require Node 8.5
 - npm: Rename `build-doc` to `build-docs`; add `open-docs` script
 - npm: Update devDeps (and our @babel/polyfill copy)
+- npm: Remove unused devDeps
 
 ## 4.3.0
 

package.json

@@ -82,11 +82,11 @@
     "@babel/plugin-transform-modules-commonjs": "^7.4.4",
     "@babel/polyfill": "^7.4.4",
     "@babel/preset-env": "^7.4.4",
-    "@mysticatea/eslint-plugin": "^10.0.2",
+    "@mysticatea/eslint-plugin": "^10.0.3",
     "axe-testcafe": "^1.1.0",
     "babel-plugin-transform-object-rest-spread": "^7.0.0-beta.3",
     "eslint": "5.16.0",
-    "eslint-config-ash-nazg": "3.0.1",
+    "eslint-config-ash-nazg": "4.0.0",
     "eslint-config-standard": "12.0.0",
     "eslint-plugin-compat": "^3.1.1",
     "eslint-plugin-eslint-comments": "^3.1.1",
@@ -94,7 +94,7 @@
     "eslint-plugin-jsdoc": "^4.8.3",
     "eslint-plugin-markdown": "^1.0.0",
     "eslint-plugin-no-use-extend-native": "^0.4.0",
-    "eslint-plugin-node": "8.0.1",
+    "eslint-plugin-node": "9.0.1",
     "eslint-plugin-promise": "4.1.1",
     "eslint-plugin-qunit": "^4.0.0",
     "eslint-plugin-standard": "4.0.0",
@@ -113,11 +113,8 @@
     "qunit": "^2.9.2",
     "remark-cli": "^6.0.1",
     "remark-lint-ordered-list-marker-value": "^1.0.2",
-    "rollup": "1.10.1",
+    "rollup": "1.11.2",
     "rollup-plugin-babel": "^4.3.2",
-    "rollup-plugin-commonjs": "^9.3.4",
-    "rollup-plugin-node-builtins": "^2.1.2",
-    "rollup-plugin-node-resolve": "^4.2.3",
     "rollup-plugin-re": "^1.0.7",
     "rollup-plugin-terser": "^4.0.4",
     "sinon": "^7.3.2",