2013-07-28 22:53:30 +00:00
|
|
|
//-----------------------------------------------------------------------------
|
|
|
|
// A library wrapper around SolveSpace, to permit someone to use its constraint
|
|
|
|
// solver without coupling their program too much to SolveSpace's internals.
|
|
|
|
//
|
|
|
|
// Copyright 2008-2013 Jonathan Westhues.
|
|
|
|
//-----------------------------------------------------------------------------
|
2009-04-20 07:30:09 +00:00
|
|
|
#include "solvespace.h"
|
2010-07-10 18:53:30 +00:00
|
|
|
#define EXPORT_DLL
|
2015-03-02 18:06:59 +00:00
|
|
|
#include <slvs.h>
|
2009-04-20 07:30:09 +00:00
|
|
|
|
2015-03-27 15:31:23 +00:00
|
|
|
Sketch SolveSpace::SK = {};
|
2013-11-18 07:31:23 +00:00
|
|
|
static System SYS;
|
2009-04-20 07:30:09 +00:00
|
|
|
|
2013-11-18 07:31:23 +00:00
|
|
|
static int IsInit = 0;
|
2009-04-20 07:30:09 +00:00
|
|
|
|
2016-05-07 23:34:21 +00:00
|
|
|
void Group::GenerateEquations(IdList<Equation,hEquation> *) {
|
2009-04-20 07:30:09 +00:00
|
|
|
// Nothing to do for now.
|
|
|
|
}
|
|
|
|
|
2016-05-07 23:34:21 +00:00
|
|
|
void SolveSpace::CnfFreezeInt(uint32_t, const std::string &)
|
2010-01-23 03:47:00 +00:00
|
|
|
{
|
2013-11-18 07:31:23 +00:00
|
|
|
abort();
|
|
|
|
}
|
|
|
|
|
2016-05-07 23:34:21 +00:00
|
|
|
uint32_t SolveSpace::CnfThawInt(uint32_t, const std::string &)
|
2013-11-18 07:31:23 +00:00
|
|
|
{
|
|
|
|
abort();
|
2013-12-08 08:32:50 +00:00
|
|
|
return 0;
|
2013-11-18 07:31:23 +00:00
|
|
|
}
|
|
|
|
|
2016-05-07 23:34:21 +00:00
|
|
|
void SolveSpace::DoMessageBox(const char *, int, int, bool)
|
2013-11-18 07:31:23 +00:00
|
|
|
{
|
|
|
|
abort();
|
2010-01-23 03:47:00 +00:00
|
|
|
}
|
|
|
|
|
2009-04-20 07:30:09 +00:00
|
|
|
extern "C" {
|
|
|
|
|
|
|
|
void Slvs_QuaternionU(double qw, double qx, double qy, double qz,
|
|
|
|
double *x, double *y, double *z)
|
|
|
|
{
|
|
|
|
Quaternion q = Quaternion::From(qw, qx, qy, qz);
|
|
|
|
Vector v = q.RotationU();
|
|
|
|
*x = v.x;
|
|
|
|
*y = v.y;
|
|
|
|
*z = v.z;
|
|
|
|
}
|
|
|
|
|
|
|
|
void Slvs_QuaternionV(double qw, double qx, double qy, double qz,
|
|
|
|
double *x, double *y, double *z)
|
|
|
|
{
|
|
|
|
Quaternion q = Quaternion::From(qw, qx, qy, qz);
|
|
|
|
Vector v = q.RotationV();
|
|
|
|
*x = v.x;
|
|
|
|
*y = v.y;
|
|
|
|
*z = v.z;
|
|
|
|
}
|
|
|
|
|
|
|
|
void Slvs_QuaternionN(double qw, double qx, double qy, double qz,
|
|
|
|
double *x, double *y, double *z)
|
|
|
|
{
|
|
|
|
Quaternion q = Quaternion::From(qw, qx, qy, qz);
|
|
|
|
Vector v = q.RotationN();
|
|
|
|
*x = v.x;
|
|
|
|
*y = v.y;
|
|
|
|
*z = v.z;
|
|
|
|
}
|
|
|
|
|
|
|
|
void Slvs_MakeQuaternion(double ux, double uy, double uz,
|
|
|
|
double vx, double vy, double vz,
|
|
|
|
double *qw, double *qx, double *qy, double *qz)
|
|
|
|
{
|
|
|
|
Vector u = Vector::From(ux, uy, uz),
|
|
|
|
v = Vector::From(vx, vy, vz);
|
|
|
|
Quaternion q = Quaternion::From(u, v);
|
|
|
|
*qw = q.w;
|
|
|
|
*qx = q.vx;
|
|
|
|
*qy = q.vy;
|
|
|
|
*qz = q.vz;
|
|
|
|
}
|
|
|
|
|
|
|
|
void Slvs_Solve(Slvs_System *ssys, Slvs_hGroup shg)
|
|
|
|
{
|
|
|
|
if(!IsInit) {
|
2016-12-05 00:25:31 +00:00
|
|
|
InitPlatform(0, NULL);
|
2009-04-20 07:30:09 +00:00
|
|
|
IsInit = 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
int i;
|
|
|
|
for(i = 0; i < ssys->params; i++) {
|
|
|
|
Slvs_Param *sp = &(ssys->param[i]);
|
2015-03-27 15:31:23 +00:00
|
|
|
Param p = {};
|
2015-03-29 00:30:52 +00:00
|
|
|
|
2009-04-20 07:30:09 +00:00
|
|
|
p.h.v = sp->h;
|
|
|
|
p.val = sp->val;
|
|
|
|
SK.param.Add(&p);
|
|
|
|
if(sp->group == shg) {
|
|
|
|
SYS.param.Add(&p);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
for(i = 0; i < ssys->entities; i++) {
|
|
|
|
Slvs_Entity *se = &(ssys->entity[i]);
|
2015-03-27 15:31:23 +00:00
|
|
|
EntityBase e = {};
|
2009-04-20 07:30:09 +00:00
|
|
|
|
|
|
|
switch(se->type) {
|
Convert all enumerations to use `enum class`.
Specifically, take the old code that looks like this:
class Foo {
enum { X = 1, Y = 2 };
int kind;
}
... foo.kind = Foo::X; ...
and convert it to this:
class Foo {
enum class Kind : uint32_t { X = 1, Y = 2 };
Kind kind;
}
... foo.kind = Foo::Kind::X;
(In some cases the enumeration would not be in the class namespace,
such as when it is generally useful.)
The benefits are as follows:
* The type of the field gives a clear indication of intent, both
to humans and tools (such as binding generators).
* The compiler is able to automatically warn when a switch is not
exhaustive; but this is currently suppressed by the
default: ssassert(false, ...)
idiom.
* Integers and plain enums are weakly type checked: they implicitly
convert into each other. This can hide bugs where type conversion
is performed but not intended. Enum classes are strongly type
checked.
* Plain enums pollute parent namespaces; enum classes do not.
Almost every defined enum we have already has a kind of ad-hoc
namespacing via `NAMESPACE_`, which is now explicit.
* Plain enums do not have a well-defined ABI size, which is
important for bindings. Enum classes can have it, if specified.
We specify the base type for all enums as uint32_t, which is
a safe choice and allows us to not change the numeric values
of any variants.
This commit introduces absolutely no functional change to the code,
just renaming and change of types. It handles almost all cases,
except GraphicsWindow::pending.operation, which needs minor
functional change.
2016-05-20 08:31:20 +00:00
|
|
|
case SLVS_E_POINT_IN_3D: e.type = Entity::Type::POINT_IN_3D; break;
|
|
|
|
case SLVS_E_POINT_IN_2D: e.type = Entity::Type::POINT_IN_2D; break;
|
|
|
|
case SLVS_E_NORMAL_IN_3D: e.type = Entity::Type::NORMAL_IN_3D; break;
|
|
|
|
case SLVS_E_NORMAL_IN_2D: e.type = Entity::Type::NORMAL_IN_2D; break;
|
|
|
|
case SLVS_E_DISTANCE: e.type = Entity::Type::DISTANCE; break;
|
|
|
|
case SLVS_E_WORKPLANE: e.type = Entity::Type::WORKPLANE; break;
|
|
|
|
case SLVS_E_LINE_SEGMENT: e.type = Entity::Type::LINE_SEGMENT; break;
|
|
|
|
case SLVS_E_CUBIC: e.type = Entity::Type::CUBIC; break;
|
|
|
|
case SLVS_E_CIRCLE: e.type = Entity::Type::CIRCLE; break;
|
|
|
|
case SLVS_E_ARC_OF_CIRCLE: e.type = Entity::Type::ARC_OF_CIRCLE; break;
|
2010-05-07 02:13:57 +00:00
|
|
|
|
|
|
|
default: dbp("bad entity type %d", se->type); return;
|
2009-04-20 07:30:09 +00:00
|
|
|
}
|
|
|
|
e.h.v = se->h;
|
|
|
|
e.group.v = se->group;
|
|
|
|
e.workplane.v = se->wrkpl;
|
|
|
|
e.point[0].v = se->point[0];
|
|
|
|
e.point[1].v = se->point[1];
|
|
|
|
e.point[2].v = se->point[2];
|
|
|
|
e.point[3].v = se->point[3];
|
|
|
|
e.normal.v = se->normal;
|
|
|
|
e.distance.v = se->distance;
|
|
|
|
e.param[0].v = se->param[0];
|
|
|
|
e.param[1].v = se->param[1];
|
|
|
|
e.param[2].v = se->param[2];
|
|
|
|
e.param[3].v = se->param[3];
|
|
|
|
|
|
|
|
SK.entity.Add(&e);
|
|
|
|
}
|
2017-01-25 16:39:26 +00:00
|
|
|
IdList<Param, hParam> params = {};
|
2009-04-20 07:30:09 +00:00
|
|
|
for(i = 0; i < ssys->constraints; i++) {
|
|
|
|
Slvs_Constraint *sc = &(ssys->constraint[i]);
|
2015-03-27 15:31:23 +00:00
|
|
|
ConstraintBase c = {};
|
2009-04-20 07:30:09 +00:00
|
|
|
|
Convert all enumerations to use `enum class`.
Specifically, take the old code that looks like this:
class Foo {
enum { X = 1, Y = 2 };
int kind;
}
... foo.kind = Foo::X; ...
and convert it to this:
class Foo {
enum class Kind : uint32_t { X = 1, Y = 2 };
Kind kind;
}
... foo.kind = Foo::Kind::X;
(In some cases the enumeration would not be in the class namespace,
such as when it is generally useful.)
The benefits are as follows:
* The type of the field gives a clear indication of intent, both
to humans and tools (such as binding generators).
* The compiler is able to automatically warn when a switch is not
exhaustive; but this is currently suppressed by the
default: ssassert(false, ...)
idiom.
* Integers and plain enums are weakly type checked: they implicitly
convert into each other. This can hide bugs where type conversion
is performed but not intended. Enum classes are strongly type
checked.
* Plain enums pollute parent namespaces; enum classes do not.
Almost every defined enum we have already has a kind of ad-hoc
namespacing via `NAMESPACE_`, which is now explicit.
* Plain enums do not have a well-defined ABI size, which is
important for bindings. Enum classes can have it, if specified.
We specify the base type for all enums as uint32_t, which is
a safe choice and allows us to not change the numeric values
of any variants.
This commit introduces absolutely no functional change to the code,
just renaming and change of types. It handles almost all cases,
except GraphicsWindow::pending.operation, which needs minor
functional change.
2016-05-20 08:31:20 +00:00
|
|
|
Constraint::Type t;
|
2009-04-20 07:30:09 +00:00
|
|
|
switch(sc->type) {
|
Convert all enumerations to use `enum class`.
Specifically, take the old code that looks like this:
class Foo {
enum { X = 1, Y = 2 };
int kind;
}
... foo.kind = Foo::X; ...
and convert it to this:
class Foo {
enum class Kind : uint32_t { X = 1, Y = 2 };
Kind kind;
}
... foo.kind = Foo::Kind::X;
(In some cases the enumeration would not be in the class namespace,
such as when it is generally useful.)
The benefits are as follows:
* The type of the field gives a clear indication of intent, both
to humans and tools (such as binding generators).
* The compiler is able to automatically warn when a switch is not
exhaustive; but this is currently suppressed by the
default: ssassert(false, ...)
idiom.
* Integers and plain enums are weakly type checked: they implicitly
convert into each other. This can hide bugs where type conversion
is performed but not intended. Enum classes are strongly type
checked.
* Plain enums pollute parent namespaces; enum classes do not.
Almost every defined enum we have already has a kind of ad-hoc
namespacing via `NAMESPACE_`, which is now explicit.
* Plain enums do not have a well-defined ABI size, which is
important for bindings. Enum classes can have it, if specified.
We specify the base type for all enums as uint32_t, which is
a safe choice and allows us to not change the numeric values
of any variants.
This commit introduces absolutely no functional change to the code,
just renaming and change of types. It handles almost all cases,
except GraphicsWindow::pending.operation, which needs minor
functional change.
2016-05-20 08:31:20 +00:00
|
|
|
case SLVS_C_POINTS_COINCIDENT: t = Constraint::Type::POINTS_COINCIDENT; break;
|
|
|
|
case SLVS_C_PT_PT_DISTANCE: t = Constraint::Type::PT_PT_DISTANCE; break;
|
|
|
|
case SLVS_C_PT_PLANE_DISTANCE: t = Constraint::Type::PT_PLANE_DISTANCE; break;
|
|
|
|
case SLVS_C_PT_LINE_DISTANCE: t = Constraint::Type::PT_LINE_DISTANCE; break;
|
|
|
|
case SLVS_C_PT_FACE_DISTANCE: t = Constraint::Type::PT_FACE_DISTANCE; break;
|
|
|
|
case SLVS_C_PT_IN_PLANE: t = Constraint::Type::PT_IN_PLANE; break;
|
|
|
|
case SLVS_C_PT_ON_LINE: t = Constraint::Type::PT_ON_LINE; break;
|
|
|
|
case SLVS_C_PT_ON_FACE: t = Constraint::Type::PT_ON_FACE; break;
|
|
|
|
case SLVS_C_EQUAL_LENGTH_LINES: t = Constraint::Type::EQUAL_LENGTH_LINES; break;
|
|
|
|
case SLVS_C_LENGTH_RATIO: t = Constraint::Type::LENGTH_RATIO; break;
|
|
|
|
case SLVS_C_EQ_LEN_PT_LINE_D: t = Constraint::Type::EQ_LEN_PT_LINE_D; break;
|
|
|
|
case SLVS_C_EQ_PT_LN_DISTANCES: t = Constraint::Type::EQ_PT_LN_DISTANCES; break;
|
|
|
|
case SLVS_C_EQUAL_ANGLE: t = Constraint::Type::EQUAL_ANGLE; break;
|
|
|
|
case SLVS_C_EQUAL_LINE_ARC_LEN: t = Constraint::Type::EQUAL_LINE_ARC_LEN; break;
|
|
|
|
case SLVS_C_LENGTH_DIFFERENCE: t = Constraint::Type::LENGTH_DIFFERENCE; break;
|
|
|
|
case SLVS_C_SYMMETRIC: t = Constraint::Type::SYMMETRIC; break;
|
|
|
|
case SLVS_C_SYMMETRIC_HORIZ: t = Constraint::Type::SYMMETRIC_HORIZ; break;
|
|
|
|
case SLVS_C_SYMMETRIC_VERT: t = Constraint::Type::SYMMETRIC_VERT; break;
|
|
|
|
case SLVS_C_SYMMETRIC_LINE: t = Constraint::Type::SYMMETRIC_LINE; break;
|
|
|
|
case SLVS_C_AT_MIDPOINT: t = Constraint::Type::AT_MIDPOINT; break;
|
|
|
|
case SLVS_C_HORIZONTAL: t = Constraint::Type::HORIZONTAL; break;
|
|
|
|
case SLVS_C_VERTICAL: t = Constraint::Type::VERTICAL; break;
|
|
|
|
case SLVS_C_DIAMETER: t = Constraint::Type::DIAMETER; break;
|
|
|
|
case SLVS_C_PT_ON_CIRCLE: t = Constraint::Type::PT_ON_CIRCLE; break;
|
|
|
|
case SLVS_C_SAME_ORIENTATION: t = Constraint::Type::SAME_ORIENTATION; break;
|
|
|
|
case SLVS_C_ANGLE: t = Constraint::Type::ANGLE; break;
|
|
|
|
case SLVS_C_PARALLEL: t = Constraint::Type::PARALLEL; break;
|
|
|
|
case SLVS_C_PERPENDICULAR: t = Constraint::Type::PERPENDICULAR; break;
|
|
|
|
case SLVS_C_ARC_LINE_TANGENT: t = Constraint::Type::ARC_LINE_TANGENT; break;
|
|
|
|
case SLVS_C_CUBIC_LINE_TANGENT: t = Constraint::Type::CUBIC_LINE_TANGENT; break;
|
|
|
|
case SLVS_C_EQUAL_RADIUS: t = Constraint::Type::EQUAL_RADIUS; break;
|
|
|
|
case SLVS_C_PROJ_PT_DISTANCE: t = Constraint::Type::PROJ_PT_DISTANCE; break;
|
|
|
|
case SLVS_C_WHERE_DRAGGED: t = Constraint::Type::WHERE_DRAGGED; break;
|
|
|
|
case SLVS_C_CURVE_CURVE_TANGENT:t = Constraint::Type::CURVE_CURVE_TANGENT; break;
|
2009-04-20 07:30:09 +00:00
|
|
|
|
|
|
|
default: dbp("bad constraint type %d", sc->type); return;
|
|
|
|
}
|
|
|
|
|
|
|
|
c.type = t;
|
|
|
|
|
|
|
|
c.h.v = sc->h;
|
|
|
|
c.group.v = sc->group;
|
|
|
|
c.workplane.v = sc->wrkpl;
|
|
|
|
c.valA = sc->valA;
|
|
|
|
c.ptA.v = sc->ptA;
|
|
|
|
c.ptB.v = sc->ptB;
|
|
|
|
c.entityA.v = sc->entityA;
|
|
|
|
c.entityB.v = sc->entityB;
|
|
|
|
c.entityC.v = sc->entityC;
|
|
|
|
c.entityD.v = sc->entityD;
|
|
|
|
c.other = (sc->other) ? true : false;
|
2010-05-10 04:14:06 +00:00
|
|
|
c.other2 = (sc->other2) ? true : false;
|
2009-04-20 07:30:09 +00:00
|
|
|
|
2017-01-25 16:39:26 +00:00
|
|
|
c.Generate(¶ms);
|
|
|
|
if(params.n > 0) {
|
|
|
|
for(Param &p : params) {
|
|
|
|
p.h = SK.param.AddAndAssignId(&p);
|
|
|
|
c.valP = p.h;
|
|
|
|
SYS.param.Add(&p);
|
|
|
|
}
|
|
|
|
params.Clear();
|
|
|
|
c.ModifyToSatisfy();
|
|
|
|
}
|
|
|
|
|
2009-04-20 07:30:09 +00:00
|
|
|
SK.constraint.Add(&c);
|
|
|
|
}
|
|
|
|
|
2013-11-18 07:31:23 +00:00
|
|
|
for(i = 0; i < (int)arraylen(ssys->dragged); i++) {
|
2009-11-03 18:54:49 +00:00
|
|
|
if(ssys->dragged[i]) {
|
|
|
|
hParam hp = { ssys->dragged[i] };
|
|
|
|
SYS.dragged.Add(&hp);
|
|
|
|
}
|
2009-04-20 07:30:09 +00:00
|
|
|
}
|
|
|
|
|
2015-03-27 15:31:23 +00:00
|
|
|
Group g = {};
|
2009-04-20 07:30:09 +00:00
|
|
|
g.h.v = shg;
|
|
|
|
|
2015-03-27 15:31:23 +00:00
|
|
|
List<hConstraint> bad = {};
|
2009-04-20 07:30:09 +00:00
|
|
|
|
|
|
|
// Now we're finally ready to solve!
|
2009-04-21 07:56:17 +00:00
|
|
|
bool andFindBad = ssys->calculateFaileds ? true : false;
|
2016-05-25 12:08:19 +00:00
|
|
|
SolveResult how = SYS.Solve(&g, &(ssys->dof), &bad, andFindBad, /*andFindFree=*/false);
|
2009-04-20 07:30:09 +00:00
|
|
|
|
|
|
|
switch(how) {
|
Convert all enumerations to use `enum class`.
Specifically, take the old code that looks like this:
class Foo {
enum { X = 1, Y = 2 };
int kind;
}
... foo.kind = Foo::X; ...
and convert it to this:
class Foo {
enum class Kind : uint32_t { X = 1, Y = 2 };
Kind kind;
}
... foo.kind = Foo::Kind::X;
(In some cases the enumeration would not be in the class namespace,
such as when it is generally useful.)
The benefits are as follows:
* The type of the field gives a clear indication of intent, both
to humans and tools (such as binding generators).
* The compiler is able to automatically warn when a switch is not
exhaustive; but this is currently suppressed by the
default: ssassert(false, ...)
idiom.
* Integers and plain enums are weakly type checked: they implicitly
convert into each other. This can hide bugs where type conversion
is performed but not intended. Enum classes are strongly type
checked.
* Plain enums pollute parent namespaces; enum classes do not.
Almost every defined enum we have already has a kind of ad-hoc
namespacing via `NAMESPACE_`, which is now explicit.
* Plain enums do not have a well-defined ABI size, which is
important for bindings. Enum classes can have it, if specified.
We specify the base type for all enums as uint32_t, which is
a safe choice and allows us to not change the numeric values
of any variants.
This commit introduces absolutely no functional change to the code,
just renaming and change of types. It handles almost all cases,
except GraphicsWindow::pending.operation, which needs minor
functional change.
2016-05-20 08:31:20 +00:00
|
|
|
case SolveResult::OKAY:
|
2009-04-20 07:30:09 +00:00
|
|
|
ssys->result = SLVS_RESULT_OKAY;
|
|
|
|
break;
|
|
|
|
|
Convert all enumerations to use `enum class`.
Specifically, take the old code that looks like this:
class Foo {
enum { X = 1, Y = 2 };
int kind;
}
... foo.kind = Foo::X; ...
and convert it to this:
class Foo {
enum class Kind : uint32_t { X = 1, Y = 2 };
Kind kind;
}
... foo.kind = Foo::Kind::X;
(In some cases the enumeration would not be in the class namespace,
such as when it is generally useful.)
The benefits are as follows:
* The type of the field gives a clear indication of intent, both
to humans and tools (such as binding generators).
* The compiler is able to automatically warn when a switch is not
exhaustive; but this is currently suppressed by the
default: ssassert(false, ...)
idiom.
* Integers and plain enums are weakly type checked: they implicitly
convert into each other. This can hide bugs where type conversion
is performed but not intended. Enum classes are strongly type
checked.
* Plain enums pollute parent namespaces; enum classes do not.
Almost every defined enum we have already has a kind of ad-hoc
namespacing via `NAMESPACE_`, which is now explicit.
* Plain enums do not have a well-defined ABI size, which is
important for bindings. Enum classes can have it, if specified.
We specify the base type for all enums as uint32_t, which is
a safe choice and allows us to not change the numeric values
of any variants.
This commit introduces absolutely no functional change to the code,
just renaming and change of types. It handles almost all cases,
except GraphicsWindow::pending.operation, which needs minor
functional change.
2016-05-20 08:31:20 +00:00
|
|
|
case SolveResult::DIDNT_CONVERGE:
|
2009-04-20 07:30:09 +00:00
|
|
|
ssys->result = SLVS_RESULT_DIDNT_CONVERGE;
|
|
|
|
break;
|
|
|
|
|
Convert all enumerations to use `enum class`.
Specifically, take the old code that looks like this:
class Foo {
enum { X = 1, Y = 2 };
int kind;
}
... foo.kind = Foo::X; ...
and convert it to this:
class Foo {
enum class Kind : uint32_t { X = 1, Y = 2 };
Kind kind;
}
... foo.kind = Foo::Kind::X;
(In some cases the enumeration would not be in the class namespace,
such as when it is generally useful.)
The benefits are as follows:
* The type of the field gives a clear indication of intent, both
to humans and tools (such as binding generators).
* The compiler is able to automatically warn when a switch is not
exhaustive; but this is currently suppressed by the
default: ssassert(false, ...)
idiom.
* Integers and plain enums are weakly type checked: they implicitly
convert into each other. This can hide bugs where type conversion
is performed but not intended. Enum classes are strongly type
checked.
* Plain enums pollute parent namespaces; enum classes do not.
Almost every defined enum we have already has a kind of ad-hoc
namespacing via `NAMESPACE_`, which is now explicit.
* Plain enums do not have a well-defined ABI size, which is
important for bindings. Enum classes can have it, if specified.
We specify the base type for all enums as uint32_t, which is
a safe choice and allows us to not change the numeric values
of any variants.
This commit introduces absolutely no functional change to the code,
just renaming and change of types. It handles almost all cases,
except GraphicsWindow::pending.operation, which needs minor
functional change.
2016-05-20 08:31:20 +00:00
|
|
|
case SolveResult::REDUNDANT_DIDNT_CONVERGE:
|
|
|
|
case SolveResult::REDUNDANT_OKAY:
|
2009-04-20 07:30:09 +00:00
|
|
|
ssys->result = SLVS_RESULT_INCONSISTENT;
|
|
|
|
break;
|
|
|
|
|
Convert all enumerations to use `enum class`.
Specifically, take the old code that looks like this:
class Foo {
enum { X = 1, Y = 2 };
int kind;
}
... foo.kind = Foo::X; ...
and convert it to this:
class Foo {
enum class Kind : uint32_t { X = 1, Y = 2 };
Kind kind;
}
... foo.kind = Foo::Kind::X;
(In some cases the enumeration would not be in the class namespace,
such as when it is generally useful.)
The benefits are as follows:
* The type of the field gives a clear indication of intent, both
to humans and tools (such as binding generators).
* The compiler is able to automatically warn when a switch is not
exhaustive; but this is currently suppressed by the
default: ssassert(false, ...)
idiom.
* Integers and plain enums are weakly type checked: they implicitly
convert into each other. This can hide bugs where type conversion
is performed but not intended. Enum classes are strongly type
checked.
* Plain enums pollute parent namespaces; enum classes do not.
Almost every defined enum we have already has a kind of ad-hoc
namespacing via `NAMESPACE_`, which is now explicit.
* Plain enums do not have a well-defined ABI size, which is
important for bindings. Enum classes can have it, if specified.
We specify the base type for all enums as uint32_t, which is
a safe choice and allows us to not change the numeric values
of any variants.
This commit introduces absolutely no functional change to the code,
just renaming and change of types. It handles almost all cases,
except GraphicsWindow::pending.operation, which needs minor
functional change.
2016-05-20 08:31:20 +00:00
|
|
|
case SolveResult::TOO_MANY_UNKNOWNS:
|
2009-04-20 07:30:09 +00:00
|
|
|
ssys->result = SLVS_RESULT_TOO_MANY_UNKNOWNS;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Write the new parameter values back to our caller.
|
|
|
|
for(i = 0; i < ssys->params; i++) {
|
|
|
|
Slvs_Param *sp = &(ssys->param[i]);
|
|
|
|
hParam hp = { sp->h };
|
|
|
|
sp->val = SK.GetParam(hp)->val;
|
|
|
|
}
|
|
|
|
|
|
|
|
if(ssys->failed) {
|
|
|
|
// Copy over any the list of problematic constraints.
|
|
|
|
for(i = 0; i < ssys->faileds && i < bad.n; i++) {
|
|
|
|
ssys->failed[i] = bad.elem[i].v;
|
|
|
|
}
|
|
|
|
ssys->faileds = bad.n;
|
|
|
|
}
|
|
|
|
|
|
|
|
bad.Clear();
|
|
|
|
SYS.param.Clear();
|
2009-04-25 01:27:45 +00:00
|
|
|
SYS.entity.Clear();
|
|
|
|
SYS.eq.Clear();
|
2009-11-03 18:54:49 +00:00
|
|
|
SYS.dragged.Clear();
|
2009-04-25 01:27:45 +00:00
|
|
|
|
2009-04-20 07:30:09 +00:00
|
|
|
SK.param.Clear();
|
|
|
|
SK.entity.Clear();
|
|
|
|
SK.constraint.Clear();
|
2013-03-15 16:43:35 +00:00
|
|
|
|
|
|
|
FreeAllTemporary();
|
2009-04-20 07:30:09 +00:00
|
|
|
}
|
|
|
|
|
2013-11-18 07:31:23 +00:00
|
|
|
} /* extern "C" */
|